Add gs_usb support in Windows build to support CANable, CAN Bus Debugger CANtact devices #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
It's also worth noting that the DLL/licence will need to be copied into the appropriate place to be distributed with a Windows release. |
|
Thanks, I want to merge this but I'll probably hold off until I have time to also configure the continuous build to package the DLL properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in Issue #238 this PR adds support for devices utilising the gs_usb protocol on Windows.
The dll that supports the protocol is licenced under the LGPL and so is appropriately compiled separately and linked dynamically. The source for the dll is available here: https://github.com/BennyEvans/candle_dll
I've tested with CANable and CAN Bus Debugger devices and with both at the same time without issue.
For transparency sake, it's worth noting that I'm the main developer of the CAN Bus Debugger device.
Let me know if there is anything that needs to be modified. I think it'll be great to add this support to the application.
Thanks again!
Ben